• xmunk@sh.itjust.works
    link
    fedilink
    arrow-up
    83
    ·
    1 year ago

    I disagree.

    Be…before I go. Could you approve all my experimental PRs?

    Real story, I have a branch that’s been open for four years at my company to add support for nested postgres transactions. It works flawlessly… but we, the senior devs, are uncertain if it’s a power that would be used responsibly by the juniors. If I’m going to walk into the light, I’m going to make sure there’s a badass explosion behind me.

    • eluvatar@programming.dev
      link
      fedilink
      arrow-up
      11
      ·
      1 year ago

      I’ve got one for a vscode feature (middle mouse click for go-to definition) that I want but the maintainers don’t think it would be used.

      • Opisek@lemmy.world
        link
        fedilink
        arrow-up
        8
        ·
        1 year ago

        I’m in the niche of niches by using vsc with a vim plugin while being a dvorak user. I rely on vim’s langmap feature to get anywhere, but people implementing vim emulators blissfully ignore accessibility like that. So I went and implemented langmap in vsc’s vim plugin myself. It has minimal intervention into the existing codebase and a bunch of other people have been wishing for this for years. Yet, when it comes to merging… Silence.

        • eluvatar@programming.dev
          link
          fedilink
          arrow-up
          4
          ·
          1 year ago

          Can’t you just open source your fork? I mean yeah it does suck but still. I’ve been in the same place and it does suck when they won’t take your PR.