• 0 Posts
  • 27 Comments
Joined 2 years ago
cake
Cake day: January 6th, 2024

help-circle
  • There are two different things mentioned here, which I feel I need to clarify:

    First, what you said about merging / creating a PR with broken tests. Absolutely you shouldn’t do that, because you should only merge once the feature is finished. If a test doesn’t work, then either it’s testing for the wrong aspect and should be rewritten, or the functionality doesn’t work 100% yet, so the feature isn’t ready to get merged. Even if you’re waiting for some other feature to get ready, because you need to integrate it or something, you’re still waiting, so the feature isn’t ready.

    At the same time, the OP’s point about tests being supposed to fail at first isn’t too far off the mark either, because that’s precisely how TDD works. If you’re applying that philosophy (which I personally condone), then that’s exactly what you do: Write the test first, checking for expected behaviour (which is taken from the specification), which will obviously fail, and only then write the code implementing that behaviour.

    But, even then, that failing test should be contained to e.g. the feature branch you’re working on, never going in a PR while it’s still failing.

    Once that feature has been merged, then yes, the test should never fail again, because that indicates a new change having sabotaged some area of that feature. Even if the new feature is considered “essential” or “high priority” while the old feature is not, ignoring the failure is one of the easiest ways to build up technical debt, so you should damn well fix that now.





  • Kayana@ttrpg.networktoich_iel@feddit.orgich🚂iel
    link
    fedilink
    arrow-up
    5
    ·
    edit-2
    5 months ago

    Ich kann an der Stelle zumindest teilweise relaten:

    Ich war in einer Verteilerliste drin, die einem die Möglichkeit gibt, eine tägliche Zusammenfassung statt lauter einzelner Mails zu erhalten. Aber mein Mail-Client hat dann wohl die Mail für zu lang befunden und nur einen Teil davon angezeigt und den Rest abgeschnitten (vielleicht als Spam-Schutz oder so, keine Ahnung). Man hatte aber auch einen sehr offensichtlichen Button, um sich die komplette Mail anzeigen zu lassen. Vielleicht hat ihr Mail-Client ja etwas ähnliches gemacht und dort war der Button dann nicht so offensichtlich?










  • That could work too, but for many people, being able to dodge/avoid hits is exclusively the DEX bonus to AC, and they believe it doesn’t have to do anything with hit points.

    I’m on two minds about that: On the one hand, it’s true that you’re far better at dodging in lighter (or no) armor. OTOH, I agree with you that experience teaches you to decide where you’re going to get hit if at all. So it might be something like “raise your arm so the strike doesn’t hit your belly”.




  • Kayana@ttrpg.networktoich_iel@feddit.deich_iel
    link
    fedilink
    Deutsch
    arrow-up
    5
    ·
    edit-2
    1 year ago

    Mein Straßenverkehrsamt tendiert dazu, bei Leuten mit nur einem Namen in ihrem (bspw. indischen) Pass einfach den Namen als Vor- und Nachnamen zu nehmen, sodass bei ihnen dann <Name> <Name> auf dem Führerschein steht… Nur, weil die deutsche Bürokratie nicht mit nur einem Namen klarkommt.